yihua commented on code in PR #11259:
URL: https://github.com/apache/hudi/pull/11259#discussion_r1608728190
##########
hudi-common/src/main/java/org/apache/hudi/io/storage/HoodieFileReaderFactory.java:
##########
@@ -40,9 +39,9 @@
*/
public class HoodieFileReaderFactory {
- protected final StorageConfiguration<?> storageConf;
- public HoodieFileReaderFactory(StorageConfiguration<?> storageConf) {
- this.storageConf = storageConf;
+ protected final HoodieStorage storage;
+ public HoodieFileReaderFactory(HoodieStorage storage) {
Review Comment:
`HoodieStorage` is not serializable. The factory should only be used on the
same JVM, not serde across machines like Spark driver and executors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
