yihua commented on code in PR #11259:
URL: https://github.com/apache/hudi/pull/11259#discussion_r1613879501
##########
hudi-common/src/main/java/org/apache/hudi/common/config/HoodieStorageConfig.java:
##########
@@ -243,7 +243,12 @@ public class HoodieStorageConfig extends HoodieConfig {
.withDocumentation("The fully-qualified class name of the factory class
to return readers and writers of files used "
+ "by Hudi. The provided class should implement
`org.apache.hudi.io.storage.HoodieIOFactory`.");
-
+ public static final ConfigProperty<String> HOODIE_STORAGE_CLASS =
ConfigProperty
Review Comment:
Rethinking about this, the reason we cannot directly use a getter to return
the `HoodieIOFactory` instance from `HoodieStorage` instance is that
`HoodieIOFactory` and related classes are in `hudi-common` module because they
use Hudi concepts such as `HoodieRecord`, `BloomFilter`, etc., while the
`HoodieStorage` is in `hudi-io` module (`hudi-common` module depends on
`hudi-io`). For now, the best way is to keep two configs. For Hadoop-based
implementation, no configs are required as the default are the
`HoodieHadoopIOFactory` and `HoodieHadoopStorage`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@hudi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
