Re: [PR] [HUDI-7805] FileSystemBasedLockProvider need delete lock file auto when occur lock conflict to avoid next write failed [hudi]

Tue, 28 May 2024 20:05:22 -0700 


xuzifu666 commented on code in PR #11347:
URL: https://github.com/apache/hudi/pull/11347#discussion_r1618120568


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/LockManager.java:
##########
@@ -81,12 +85,16 @@ public void lock() {
         metrics.startLockApiTimerContext();
         if 
(!getLockProvider().tryLock(writeConfig.getLockAcquireWaitTimeoutInMs(), 
TimeUnit.MILLISECONDS)) {
           metrics.updateLockNotAcquiredMetric();
+          if (getLockProvider() instanceof FileSystemBasedLockProvider) {
+            fs.delete(new Path(((FileSystemBasedLockProvider) 
getLockProvider()).getLock()), true);

Review Comment:
   @danny0405 getCurrentOwnerLockInfo is not fitable due to it is file content, 
not the path stringļ¼Œso keep it with getLock



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to