xuzifu666 commented on code in PR #11347:
URL: https://github.com/apache/hudi/pull/11347#discussion_r1618120568
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/transaction/lock/LockManager.java:
##########
@@ -81,12 +85,16 @@ public void lock() {
metrics.startLockApiTimerContext();
if
(!getLockProvider().tryLock(writeConfig.getLockAcquireWaitTimeoutInMs(),
TimeUnit.MILLISECONDS)) {
metrics.updateLockNotAcquiredMetric();
+ if (getLockProvider() instanceof FileSystemBasedLockProvider) {
+ fs.delete(new Path(((FileSystemBasedLockProvider)
getLockProvider()).getLock()), true);
Review Comment:
@danny0405 getCurrentOwnerLockInfo is not fitable due to it is file content
string, not the path string，so keep it with getLock：
2192894 [Thread-54214] WARN
org.apache.hudi.common.table.log.HoodieLogFormatWriter [] - running
logformatwriter hook
2192907 [Thread-62779] WARN
org.apache.hudi.common.table.log.HoodieLogFormatWriter [] - running
logformatwriter hook
2192907 [Thread-62781] WARN
org.apache.hudi.common.table.log.HoodieLogFormatWriter [] - running
logformatwriter hook
[INFO]
[INFO] Results:
[INFO]
[ERROR] Failures:
[ERROR] TestHoodieClientMultiWriter.testHoodieClientBasicMultiWriter:374
expected: <true> but was: <false>
[ERROR] TestHoodieClientMultiWriter.testHoodieClientBasicMultiWriter:374
expected: <true> but was: <false>
[ERROR] TestHoodieClientMultiWriter.testHoodieClientBasicMultiWriter:374
expected: <true> but was: <false>
[ERROR] TestHoodieClientMultiWriter.testHoodieClientBasicMultiWriter:374
expected: <true> but was: <false>
[ERROR] Errors:
[ERROR]
TestHoodieClientMultiWriter.testMultiWriterWithAsyncTableServicesWithConflict »
IO
[ERROR]
TestHoodieClientMultiWriter.testMultiWriterWithAsyncTableServicesWithConflict:570
» Execution
[ERROR]
TestHoodieClientMultiWriter.testMultiWriterWithAsyncTableServicesWithConflict:570
» Execution
[ERROR]
TestHoodieClientMultiWriter.testMultiWriterWithAsyncTableServicesWithConflict:570
» Execution
[INFO]
[ERROR] Tests run: 581, Failures: 4, Errors: 4, Skipped: 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
