KnightChess commented on code in PR #8233:
URL: https://github.com/apache/hudi/pull/8233#discussion_r1623133643
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala:
##########
@@ -123,6 +126,24 @@ object HoodieSparkSqlWriter {
streamingWritesParamsOpt: Option[StreamingWriteParams] =
Option.empty,
hoodieWriteClient: Option[SparkRDDWriteClient[_]] = Option.empty):
(Boolean, HOption[String], HOption[String], HOption[String],
SparkRDDWriteClient[_], HoodieTableConfig) = {
+ //TODO reuse DataWritingCommand sparkPlan, reduce the number of sql list
in SPARK UI SQL tag, rendering raw DAG
Review Comment:
@codope Sorry to reply late, no overhead, just in the SQL TAB, it doesn't
look beautiful. the TODO is hard fix now, because we reproduct logical plan in
hudi command plan. I will open new pr to tracking fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
