danny0405 commented on code in PR #11445:
URL: https://github.com/apache/hudi/pull/11445#discussion_r1639080670
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java:
##########
@@ -713,11 +714,24 @@ private void
deleteInvalidFilesByPartitions(HoodieEngineContext context, Map<Str
final HoodieStorage storage = metaClient.getStorage();
LOG.info("Deleting invalid data file=" + partitionFilePair);
// Delete
- try {
- storage.deleteFile(new StoragePath(partitionFilePair.getValue()));
- } catch (IOException e) {
- throw new HoodieIOException(e.getMessage(), e);
- }
+ RetryHelper<Void, HoodieIOException> retryHelper = new
RetryHelper(5000, 3, 5000, HoodieIOException.class.getName())
+ .tryWith(() -> {
Review Comment:
The retry helper actually starts a thread, there is concern we start too
many threads in file deletion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
