danny0405 commented on code in PR #11580:
URL: https://github.com/apache/hudi/pull/11580#discussion_r1680173578
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/rollback/BaseRollbackPlanActionExecutor.java:
##########
@@ -113,6 +113,7 @@ protected Option<HoodieRollbackPlan> requestRollback(String
startRollbackTime) {
HoodieRollbackPlan rollbackPlan = new HoodieRollbackPlan(new
HoodieInstantInfo(instantToRollback.getTimestamp(),
instantToRollback.getAction()), rollbackRequests,
LATEST_ROLLBACK_PLAN_VERSION);
if (!skipTimelinePublish) {
+ table.validateForLatestTimestamp(rollbackInstant.getTimestamp());
Review Comment:
I have checked https://issues.apache.org/jira/browse/HUDI-7507, it looks
like the `TrueTime` API on master can guarantee that each timestamp is the
latest (or monotonically increasing), so the main problem here is the time
generation in memory and the write of requested file are not put into the same
trasanction, can we put them in one transaction just like what we do to the
completion time for completed metadata files on master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
