wombatu-kun commented on code in PR #11664:
URL: https://github.com/apache/hudi/pull/11664#discussion_r1687364371
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/config/KafkaSourceConfig.java:
##########
@@ -66,14 +66,6 @@ public class KafkaSourceConfig extends HoodieConfig {
.markAdvanced()
.withDocumentation("Schema to deserialize the records.");
-
- public static final ConfigProperty<Long> KAFKA_FETCH_PARTITION_TIME_OUT =
ConfigProperty
- .key(PREFIX + "fetch_partition.time.out")
Review Comment:
This param was used in the only place - from client side in method
`KafkaOffsetGen.fetchPartitionInfos(..)`. When this time-out kicked in,
KafkaOffsetGen is not retrying to get `partitionsFor(topicName)` from
KafkaConsumer anymore.
But now we introduce HoodieRetyingKafkaConsumer, which already contains
retrying mechanism in itself (with exponential backoff) and retrying policy is
configured by MAX_RETRY_INTERVAL_MS, MAX_RETRY_INTERVAL_MS and MAX_RETRY_COUNT.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
