danny0405 commented on code in PR #11664:
URL: https://github.com/apache/hudi/pull/11664#discussion_r1694396621
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/config/KafkaSourceConfig.java:
##########
@@ -66,14 +66,6 @@ public class KafkaSourceConfig extends HoodieConfig {
.markAdvanced()
.withDocumentation("Schema to deserialize the records.");
-
- public static final ConfigProperty<Long> KAFKA_FETCH_PARTITION_TIME_OUT =
ConfigProperty
- .key(PREFIX + "fetch_partition.time.out")
Review Comment:
We should keep the legacy behavior too, that is the meaning of
compatibility. Another choice is we log some warnings and tell user the new
params have been taking effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]