jonvex commented on code in PR #11649: URL: https://github.com/apache/hudi/pull/11649#discussion_r1690063178
########## hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HiveHoodieReaderContext.java: ########## @@ -89,41 +84,17 @@ public class HiveHoodieReaderContext extends HoodieReaderContext<ArrayWritable> private final String recordKeyField; protected HiveHoodieReaderContext(HoodieFileGroupReaderBasedRecordReader.HiveReaderCreator readerCreator, Review Comment: reader context shouldn't be initialized with things specific to a particular fg. Got rid of some unused inputs, and moved the calculations for some things like tablename, partition cols, and recordkey field into the reader so that this class doesn't have big dependencies on things like metaclient etc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
