jonvex commented on code in PR #11649:
URL: https://github.com/apache/hudi/pull/11649#discussion_r1690066612
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieFileGroupReaderBasedRecordReader.java:
##########
@@ -206,10 +232,10 @@ private static String getLatestCommitTime(InputSplit
split, HoodieTableMetaClien
}
/**
- * Convert FileSplit to FileSlice, but save the locations in 'hosts' because
that data is otherwise lost.
+ * Convert FileSplit to FileSlice
*/
- private static FileSlice getFileSliceFromSplit(FileSplit split, Map<String,
String[]> hosts, FileSystem fs, String tableBasePath) throws IOException {
Review Comment:
got rid of hosts, will create a followup pr to allow this info and other
engine specific file things to get passed naturally through the filegroup
structure
##########
hudi-hadoop-mr/src/main/java/org/apache/hudi/hadoop/HoodieFileGroupReaderBasedRecordReader.java:
##########
@@ -206,10 +232,10 @@ private static String getLatestCommitTime(InputSplit
split, HoodieTableMetaClien
}
/**
- * Convert FileSplit to FileSlice, but save the locations in 'hosts' because
that data is otherwise lost.
+ * Convert FileSplit to FileSlice
*/
- private static FileSlice getFileSliceFromSplit(FileSplit split, Map<String,
String[]> hosts, FileSystem fs, String tableBasePath) throws IOException {
Review Comment:
got rid of hosts, will create a followup ticket to allow this info and other
engine specific file things to get passed naturally through the filegroup
structure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
