xushiyan commented on code in PR #100: URL: https://github.com/apache/hudi-rs/pull/100#discussion_r1693994201
########## .pre-commit-config.yaml: ########## @@ -0,0 +1,39 @@ +repos: + - repo: https://github.com/pre-commit/pre-commit-hooks + rev: v4.6.0 + hooks: + - id: trailing-whitespace + - id: end-of-file-fixer + - id: check-yaml + - id: check-json + - id: check-added-large-files + - id: check-merge-conflict + + - repo: https://github.com/psf/black + rev: 24.4.2 + hooks: + - id: black + language_version: python3 + args: ["--line-length", "120"] + + - repo: https://github.com/PyCQA/flake8 + rev: 7.1.0 + hooks: + - id: flake8 + additional_dependencies: [flake8-bugbear] + args: ["--max-line-length", "120", "--ignore=F401"] + + - repo: https://github.com/pre-commit/mirrors-mypy + rev: v1.11.0 + hooks: + - id: mypy + args: [ "--ignore-missing-imports" ] Review Comment: can all the python tools settings be put in `pyproject.toml` ? we can use section like `[tool.mypy]`, `[tool.ruff]` ? we can use [ruff](https://github.com/astral-sh/ruff) instead of flake8+black, much faster -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
