xushiyan commented on PR #100: URL: https://github.com/apache/hudi-rs/pull/100#issuecomment-2257498664
> > > > Rust dependency: arrow_schema::Schema::all_fields: Use flattened_fields instead. > > > > > > > > > @muyihao looks like this is reported by clippy - yes feel free to raise another PR to fix the clippy warning, then we can land the python style change PR without touching rust code > > > > > > @muyihao interestingly clippy is checking against arrow 52.2.0 despite that cargo workspace is setting it to 52.0.0. do you know if we can make clippy to respect the exact dep version for checking? we may not want to upgrade arrow just because clippy complains - the rust code fix can be done when we manually decide to upgrade arrow. > > To ensure the project runs consistently across different environments, we should include the Cargo.lock file. hmmm that'd actually be an overkill, as lock file is generally not recommended for lib repo. the root fix is on the dep version itself (https://github.com/apache/hudi-rs/commit/75663379bf3cbf794af2fcf3823045f07851754c). I've updated your style change PR - will make some setting tweaks and then merge it. We can now close this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
