lokeshj1703 commented on code in PR #11149:
URL: https://github.com/apache/hudi/pull/11149#discussion_r1728734925
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/HoodieMultiTableStreamer.java:
##########
@@ -430,6 +432,99 @@ public static class Config implements Serializable {
@Parameter(names = {"--help", "-h"}, help = true)
public Boolean help = false;
+
+ @Override
+ public boolean equals(Object o) {
Review Comment:
Do we need the equals and toString implementation here?
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/streamer/TestStreamSyncUnitTests.java:
##########
@@ -160,6 +165,45 @@ void testGetCheckpointToResume(HoodieStreamer.Config cfg,
HoodieCommitMetadata c
assertEquals(expectedResumeCheckpoint,resumeCheckpoint);
}
+ @ParameterizedTest
+ @MethodSource("getMultiTableStreamerCases")
+ void testCloneConfigsFromMultiTableStreamer(HoodieMultiTableStreamer.Config
cfg) throws IOException {
+ Configuration configuration = new Configuration();
+ JavaSparkContext jssc = mock(JavaSparkContext.class);
+
+ when(jssc.hadoopConfiguration()).thenReturn(configuration);
+
+ HoodieMultiTableStreamer multiTableStreamer = new
HoodieMultiTableStreamer(cfg, jssc);
+ List<TableExecutionContext> tableExecutionContextList =
multiTableStreamer.getTableExecutionContexts();
+ tableExecutionContextList.forEach(it -> {
+ // make sure that if set global properties then each child streamer can
get also
+ assertTrue(it.getConfig().configs.containsAll(cfg.configs));
Review Comment:
Can we also add a check for `cfg.configs` to be non empty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
