lokeshj1703 commented on code in PR #11149:
URL: https://github.com/apache/hudi/pull/11149#discussion_r1730720592
##########
hudi-utilities/src/test/java/org/apache/hudi/utilities/streamer/TestStreamSyncUnitTests.java:
##########
@@ -160,6 +165,45 @@ void testGetCheckpointToResume(HoodieStreamer.Config cfg,
HoodieCommitMetadata c
assertEquals(expectedResumeCheckpoint,resumeCheckpoint);
}
+ @ParameterizedTest
+ @MethodSource("getMultiTableStreamerCases")
+ void testCloneConfigsFromMultiTableStreamer(HoodieMultiTableStreamer.Config
cfg) throws IOException {
+ Configuration configuration = new Configuration();
+ JavaSparkContext jssc = mock(JavaSparkContext.class);
+
+ when(jssc.hadoopConfiguration()).thenReturn(configuration);
+
+ HoodieMultiTableStreamer multiTableStreamer = new
HoodieMultiTableStreamer(cfg, jssc);
+ List<TableExecutionContext> tableExecutionContextList =
multiTableStreamer.getTableExecutionContexts();
+ tableExecutionContextList.forEach(it -> {
+ // make sure that if set global properties then each child streamer can
get also
+ assertTrue(it.getConfig().configs.containsAll(cfg.configs));
Review Comment:
I just wanted to ensure we have a test which covers the case where the
configs are non empty. I see that is already covered based on the test cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
