vinishjail97 commented on code in PR #11758:
URL: https://github.com/apache/hudi/pull/11758#discussion_r1747053625
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/BulkInsertPartitioner.java:
##########
@@ -83,20 +84,28 @@ default Option<WriteHandleFactory>
getWriteHandleFactory(int partitionId) {
/*
* If possible, we want to sort the data by partition path. Doing so will
reduce the number of files written.
+ * Suffix the recordKeys as well if
BULKINSERT_SUFFIX_RECORD_KEY_FOR_USER_DEFINED_SORT_COLUMNS is enabled, this
reduces skew.
* This will not change the desired sort order, it is just a performance
improvement.
**/
- static String[] tryPrependPartitionPathColumns(String[] columnNames,
HoodieWriteConfig config) {
+ static String[] tryPrependPartitionPathAndSuffixRecordKeyColumns(String[]
columnNames, HoodieWriteConfig config) {
Review Comment:
Updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
