nsivabalan commented on code in PR #11951:
URL: https://github.com/apache/hudi/pull/11951#discussion_r1769274191
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/index/functional/BaseHoodieIndexClient.java:
##########
@@ -61,4 +62,9 @@ public void register(HoodieTableMetaClient metaClient, String
indexName, String
* Create a functional index.
*/
public abstract void create(HoodieTableMetaClient metaClient, String
indexName, String indexType, Map<String, Map<String, String>> columns,
Map<String, String> options);
+
+ /**
+ * Drop an index. By default, ignore drop if index does not exist.
+ */
+ public abstract void drop(HoodieTableMetaClient metaClient, String
indexName, MetadataPartitionType metadataPartitionType, boolean
ignoreIfNotExists);
Review Comment:
oh I see you are getting the index name too.
can we add java docs then.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/index/functional/BaseHoodieIndexClient.java:
##########
@@ -61,4 +62,9 @@ public void register(HoodieTableMetaClient metaClient, String
indexName, String
* Create a functional index.
*/
public abstract void create(HoodieTableMetaClient metaClient, String
indexName, String indexType, Map<String, Map<String, String>> columns,
Map<String, String> options);
+
+ /**
+ * Drop an index. By default, ignore drop if index does not exist.
+ */
+ public abstract void drop(HoodieTableMetaClient metaClient, String
indexName, MetadataPartitionType metadataPartitionType, boolean
ignoreIfNotExists);
Review Comment:
isn't the 3rd arg is needs fixes?
for sec and functional, the partition type could be same, but it could refer
to diff indexes depending on the col we built the index on.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/index/functional/BaseHoodieIndexClient.java:
##########
@@ -61,4 +62,9 @@ public void register(HoodieTableMetaClient metaClient, String
indexName, String
* Create a functional index.
*/
public abstract void create(HoodieTableMetaClient metaClient, String
indexName, String indexType, Map<String, Map<String, String>> columns,
Map<String, String> options);
+
+ /**
+ * Drop an index. By default, ignore drop if index does not exist.
+ */
+ public abstract void drop(HoodieTableMetaClient metaClient, String
indexName, MetadataPartitionType metadataPartitionType, boolean
ignoreIfNotExists);
Review Comment:
also, can we compute the metadataPartitionType internally.
```
val metadataPartitionType =
MetadataPartitionType.fromPartitionPath(indexName)
```
we don't need the 3rd arg then.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
