codope commented on code in PR #11951:
URL: https://github.com/apache/hudi/pull/11951#discussion_r1769484179
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/index/functional/BaseHoodieIndexClient.java:
##########
@@ -61,4 +62,9 @@ public void register(HoodieTableMetaClient metaClient, String
indexName, String
* Create a functional index.
*/
public abstract void create(HoodieTableMetaClient metaClient, String
indexName, String indexType, Map<String, Map<String, String>> columns,
Map<String, String> options);
+
+ /**
+ * Drop an index. By default, ignore drop if index does not exist.
+ */
+ public abstract void drop(HoodieTableMetaClient metaClient, String
indexName, MetadataPartitionType metadataPartitionType, boolean
ignoreIfNotExists);
Review Comment:
I have removed `metadataPartitionType` argument. On `ignoreIfNotExists`, we
support two types of DROP INDEX statements:
```
DROP INDEX <index_name> ON <table_name>;
DROP INDEX IF EXISTS <index_name> ON <table_name>;
```
In the first case `ignoreIfNotExists` is false while true in the latter
case. So, in the sql prompt, the error will be thrown if ignore is set to false
so that user knows that the index already doesn't exist. Just need this to
support different sql flavors.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
