KnightChess commented on code in PR #119:
URL: https://github.com/apache/hudi-rs/pull/119#discussion_r1770776944
##########
crates/core/src/table/partitions.rs:
##########
@@ -289,59 +267,6 @@ impl TryFrom<(&str, &HashMap<String, DataType>)> for
HudiTablePartition {
#[cfg(test)]
mod tests {
use super::*;
- use serde_json::json;
-
- fn check_json_serialize(filter: PartitionFilter, expected_json: &str) {
- assert_eq!(serde_json::to_value(filter).unwrap(), json!(expected_json))
- }
-
- #[test]
- fn test_serialize_partition_filter() {
Review Comment:
@xushiyan arrow scalar not implement `Display`, and I found the scenes that
are not used at present, so I remove `Serialize` trait. If necessary, I can add
implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
