xushiyan commented on code in PR #119:
URL: https://github.com/apache/hudi-rs/pull/119#discussion_r1770838938
##########
crates/core/src/table/partitions.rs:
##########
@@ -289,59 +267,6 @@ impl TryFrom<(&str, &HashMap<String, DataType>)> for
HudiTablePartition {
#[cfg(test)]
mod tests {
use super::*;
- use serde_json::json;
-
- fn check_json_serialize(filter: PartitionFilter, expected_json: &str) {
- assert_eq!(serde_json::to_value(filter).unwrap(), json!(expected_json))
- }
-
- #[test]
- fn test_serialize_partition_filter() {
Review Comment:
ok i see. let me do some refactoring. i'll take this to the finish line.
thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
