yihua commented on code in PR #12056:
URL: https://github.com/apache/hudi/pull/12056#discussion_r1792600055
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieFileIndex.scala:
##########
@@ -183,9 +183,9 @@ case class HoodieFileIndex(spark: SparkSession,
}).filter(slice => slice != null)
.map(fileInfo => new FileStatus(fileInfo.getLength,
fileInfo.isDirectory, 0, fileInfo.getBlockSize,
fileInfo.getModificationTime, new Path(fileInfo.getPath.toUri)))
- val c = fileSlices.filter(f => (includeLogFiles &&
f.getLogFiles.findAny().isPresent)
- || (f.getBaseFile.isPresent &&
f.getBaseFile.get().getBootstrapBaseFile.isPresent)).
- foldLeft(Map[String, FileSlice]()) { (m, f) => m + (f.getFileId ->
f) }
+ val c = fileSlices.filter(f => f.hasBootstrapBase ||
(includeLogFiles && f.hasLogFiles))
Review Comment:
I'm a bit confused. Is this method supposed to return base files only
(based on the comment `Invoked by Spark to fetch list of latest base files per
partition`) or is it supposed to return log files? Let's fix the doc so it is
accurate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
