jonvex commented on code in PR #12056:
URL: https://github.com/apache/hudi/pull/12056#discussion_r1797101689


##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/HoodieFileIndex.scala:
##########
@@ -319,7 +320,7 @@ case class HoodieFileIndex(spark: SparkSession,
     val prunedPartitionsTuple: (Boolean, Seq[PartitionPath]) =
       if (isPartitionedTable && partitionFilters.nonEmpty) {
         // For partitioned table and partition filters, prune the partitions 
by the partition filters
-        if (shouldEmbedFileSlices) {
+        if (shouldConvertFilter) {

Review Comment:
   In the datasource implementation, the filter conversion is done inside the 
relation. But for the hadoopfsfactory, it still needs to be called. 
shouldEmbedFileSlices was originally set to true whenever we used the fg 
reader, but now that we are more selective, it needs to be controlled by a 
separate variable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to