yihua commented on code in PR #11947:
URL: https://github.com/apache/hudi/pull/11947#discussion_r1797770211
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/IncrementalQueryAnalyzer.java:
##########
@@ -471,5 +500,20 @@ public HoodieTimeline getActiveTimeline() {
public @Nullable HoodieTimeline getArchivedTimeline() {
return archivedTimeline;
}
+
+ public Option<String> getPredicateFilter() {
+ return predicateFilter;
+ }
+
+ public QueryContext withUpdatedEndInstant(String endInstant) {
+ return new QueryContext(
+ startInstant.get(),
+ endInstant,
+ instants,
+ archivedInstants,
+ activeInstants,
+ activeTimeline,archivedTimeline,
+ null);
+ }
Review Comment:
Should we avoid this API to disallow changing the result?
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/CompletionTimeQueryView.java:
##########
@@ -223,6 +224,25 @@ public List<String> getStartTimes(
InstantRange.RangeType.CLOSED_CLOSED, earliestInstantTimeFunc);
}
+ /**
+ * Queries the instant start time with given completion time range.
+ *
+ * @param rangeStart The query range start completion time.
+ * @param rangeEnd The query range end completion time.
+ * @param rangeType The range type.
+ * with the minimum completion time.
+ *
+ * @return The sorted instant time list.
+ */
+ @VisibleForTesting
+ public List<String> getStartTimes(
+ String rangeStart,
+ String rangeEnd,
Review Comment:
```suggestion
String rangeStartCompletionTime,
String rangeEndCompletionTime,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
