CTTY commented on code in PR #11947:
URL: https://github.com/apache/hudi/pull/11947#discussion_r1797780363
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java:
##########
@@ -532,6 +532,13 @@ public boolean isBeforeTimelineStarts(String instant) {
&& compareTimestamps(instant, LESSER_THAN,
firstNonSavepointCommit.get().getTimestamp());
}
+ @Override
+ public boolean isBeforeTimelineStartsByCompletionTime(String completionTime)
{
+ Option<HoodieInstant> firstNonSavepointCommit =
getFirstNonSavepointCommit();
Review Comment:
Good catch! Will fix this. I think adding a new variable
`firstNonSavepointCommitByCompletionTime` in timeline would make sense so we
can cache this result. And we can reuse the existing logic to get
`firstNonSavepointCommit` but use `completionTime` instead when comparing
instants
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
