CTTY commented on code in PR #11947:
URL: https://github.com/apache/hudi/pull/11947#discussion_r1798104588
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestIncrementalReadWithFullTableScan.scala:
##########
@@ -70,9 +70,11 @@ class TestIncrementalReadWithFullTableScan extends
HoodieSparkClientTestBase {
HoodieWriteConfig.TBL_NAME.key -> "hoodie_test",
HoodieMetadataConfig.COMPACT_NUM_DELTA_COMMITS.key -> "1"
)
+
+
// Create 10 commits
for (i <- 1 to 10) {
- val records = recordsToStrings(dataGen.generateInserts("%05d".format(i),
perBatchSize)).asScala.toList
+ val records =
recordsToStrings(dataGen.generateInserts(System.currentTimeMillis(),
perBatchSize)).asScala.toList
Review Comment:
There are some tests in `TestHoodieIncrSource` that has instant times don't
match completion time to test hollow commits handling that can be used to test
this feature.
I've filed a jira to further improve the test coverage:
https://issues.apache.org/jira/browse/HUDI-8356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
