danny0405 commented on code in PR #11947:
URL: https://github.com/apache/hudi/pull/11947#discussion_r1798653149
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/CompletionTimeQueryView.java:
##########
@@ -189,46 +193,78 @@ public Option<String> getCompletionTime(String beginTime)
{
* <p>By default, assumes there is at most 1 day time of duration for an
instant to accelerate the queries.
*
* @param timeline The timeline.
- * @param rangeStart The query range start completion time.
- * @param rangeEnd The query range end completion time.
+ * @param rangeStartCompletionTime The query range start completion time.
+ * @param rangeEndCompletionTime The query range end completion time.
* @param rangeType The range type.
*
* @return The sorted instant time list.
*/
public List<String> getStartTimes(
HoodieTimeline timeline,
- Option<String> rangeStart,
- Option<String> rangeEnd,
+ Option<String> rangeStartCompletionTime,
Review Comment:
`beginCompletionTime` and `endCompletionTime`, can you also fix the doc
indentation to be left justifying.
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/CompletionTimeQueryView.java:
##########
@@ -189,46 +193,78 @@ public Option<String> getCompletionTime(String beginTime)
{
* <p>By default, assumes there is at most 1 day time of duration for an
instant to accelerate the queries.
*
* @param timeline The timeline.
- * @param rangeStart The query range start completion time.
- * @param rangeEnd The query range end completion time.
+ * @param rangeStartCompletionTime The query range start completion time.
+ * @param rangeEndCompletionTime The query range end completion time.
* @param rangeType The range type.
*
* @return The sorted instant time list.
*/
public List<String> getStartTimes(
HoodieTimeline timeline,
- Option<String> rangeStart,
- Option<String> rangeEnd,
+ Option<String> rangeStartCompletionTime,
+ Option<String> rangeEndCompletionTime,
InstantRange.RangeType rangeType) {
// assumes any instant/transaction lasts at most 1 day to optimize the
query efficiency.
- return getStartTimes(timeline, rangeStart, rangeEnd, rangeType, s ->
HoodieInstantTimeGenerator.instantTimeMinusMillis(s, MILLI_SECONDS_IN_ONE_DAY));
+ return getStartTimes(
+ timeline,
+ rangeStartCompletionTime,
+ rangeEndCompletionTime,
+ rangeType,
+ GET_INSTANT_ONE_DAY_BEFORE);
}
/**
* Queries the instant start time with given completion time range.
*
- * @param rangeStart The query range start completion time.
- * @param rangeEnd The query range end completion time.
+ * @param rangeStartCompletionTime The query range start
completion time.
+ * @param rangeEndCompletionTime The query range end
completion time.
Review Comment:
ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
