wangxianghu commented on a change in pull request #1827:
URL: https://github.com/apache/hudi/pull/1827#discussion_r484828652
##########
File path: style/checkstyle.xml
##########
@@ -62,7 +62,7 @@
<property name="allowNonPrintableEscapes" value="true"/>
</module>
<module name="LineLength">
- <property name="max" value="200"/>
+ <property name="max" value="500"/>
Review comment:
> let's discuss this in a separate PR? 500 is a really large threshold
very sorry to say this ...
According to the current abstraction，some declaration of the method is
longer than 200.
such as
`org.apache.hudi.table.action.compact.HoodieSparkMergeOnReadTableCompactor#generateCompactionPlan`
It is 357 characters long
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
