wangxianghu commented on a change in pull request #1827:
URL: https://github.com/apache/hudi/pull/1827#discussion_r484925689
##########
File path:
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/commit/BaseMergeHelper.java
##########
@@ -161,11 +108,11 @@ private static GenericRecord
transformRecordBasedOnNewSchema(GenericDatumReader<
/**
* Consumer that dequeues records from queue and sends to Merge Handle.
*/
- private static class UpdateHandler extends
BoundedInMemoryQueueConsumer<GenericRecord, Void> {
+ static class UpdateHandler extends
BoundedInMemoryQueueConsumer<GenericRecord, Void> {
- private final HoodieMergeHandle upsertHandle;
+ private final HoodieWriteHandle upsertHandle;
Review comment:
> why is this no longer a mergeHandle?
`HoodieWriteHandle` is spark-free, while `HoodieMergeHandle` is not. To
abstract `MergeHelper`, the variables it holds should be spark-free too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
