xushiyan commented on code in PR #162:
URL: https://github.com/apache/hudi-rs/pull/162#discussion_r1799924527


##########
crates/datafusion/src/lib.rs:
##########
@@ -143,12 +143,36 @@ impl TableProvider for HudiDataSource {
     }
 }
 
+pub struct HudiTableFactory;
+
+#[async_trait]
+impl TableProviderFactory for HudiTableFactory {
+    async fn create(
+        &self,
+        _state: &dyn Session,

Review Comment:
   should also take configs from session?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to