kazdy commented on code in PR #162:
URL: https://github.com/apache/hudi-rs/pull/162#discussion_r1800000847
##########
crates/datafusion/src/lib.rs:
##########
@@ -143,12 +143,36 @@ impl TableProvider for HudiDataSource {
}
}
+pub struct HudiTableFactory;
+
+#[async_trait]
+impl TableProviderFactory for HudiTableFactory {
+ async fn create(
+ &self,
+ _state: &dyn Session,
Review Comment:
I don't see this being used in other implementations (PostgreSQL and duckdb):
https://github.com/datafusion-contrib/datafusion-table-providers/blob/ce93f2c916fcd57d1d5b7339e64963c3a72d3673/src/postgres.rs#L199
https://github.com/datafusion-contrib/datafusion-table-providers/blob/ce93f2c916fcd57d1d5b7339e64963c3a72d3673/src/duckdb.rs#L208
passing it here feels redundant as TableProvider::scan already provides a
session, but I'm not sure really, this seem to work as is
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
