wangxianghu commented on a change in pull request #1827:
URL: https://github.com/apache/hudi/pull/1827#discussion_r485027583
##########
File path:
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/io/HoodieSparkMergeHandle.java
##########
@@ -71,34 +77,25 @@
protected boolean useWriterSchema;
private HoodieBaseFile baseFileToMerge;
- public HoodieMergeHandle(HoodieWriteConfig config, String instantTime,
HoodieTable<T> hoodieTable,
- Iterator<HoodieRecord<T>> recordItr, String partitionPath, String
fileId, SparkTaskContextSupplier sparkTaskContextSupplier) {
- super(config, instantTime, partitionPath, fileId, hoodieTable,
sparkTaskContextSupplier);
+ public HoodieSparkMergeHandle(HoodieWriteConfig config, String instantTime,
HoodieTable hoodieTable,
+ Iterator<HoodieRecord<T>> recordItr, String
partitionPath, String fileId, TaskContextSupplier taskContextSupplier) {
+ super(config, instantTime, partitionPath, fileId, hoodieTable,
taskContextSupplier);
init(fileId, recordItr);
init(fileId, partitionPath,
hoodieTable.getBaseFileOnlyView().getLatestBaseFile(partitionPath,
fileId).get());
}
/**
* Called by compactor code path.
*/
- public HoodieMergeHandle(HoodieWriteConfig config, String instantTime,
HoodieTable<T> hoodieTable,
- Map<String, HoodieRecord<T>> keyToNewRecords, String partitionPath,
String fileId,
- HoodieBaseFile dataFileToBeMerged, SparkTaskContextSupplier
sparkTaskContextSupplier) {
- super(config, instantTime, partitionPath, fileId, hoodieTable,
sparkTaskContextSupplier);
+ public HoodieSparkMergeHandle(HoodieWriteConfig config, String instantTime,
HoodieTable hoodieTable,
+ Map<String, HoodieRecord<T>> keyToNewRecords,
String partitionPath, String fileId,
+ HoodieBaseFile dataFileToBeMerged,
TaskContextSupplier taskContextSupplier) {
+ super(config, instantTime, partitionPath, fileId, hoodieTable,
taskContextSupplier);
this.keyToNewRecords = keyToNewRecords;
this.useWriterSchema = true;
init(fileId, this.partitionPath, dataFileToBeMerged);
}
- @Override
Review comment:
> please refrain from moving methods around within the file. it makes
life hard during review :(
sorry for the inconvenient, let me see what I can do to avoid this :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
