wangxianghu commented on pull request #1827: URL: https://github.com/apache/hudi/pull/1827#issuecomment-688918271
> One more pass. > > @wangxianghu do the tests pass locally? 50 min is the travis limit, if its consistently exceeding that limit, we need to understand why and fix it. I can help unblock once you help me with the details. > > @wangxianghu can you confirm that there are no logic changes in this PR? High level it seems ok to me. Hardest/time consuming part of the review is actually, comparing line by line for any changes in the base/child classes everywhere. If you can give me some guidance, I can finish the review quickly Hi @vinothchandar, there are no logic changes in this PR, just as you said purely refactoring and templatizing. The unit test in my local is ok. I'll give a list of the methods moved between base/child classes. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
