xicm commented on code in PR #12101:
URL: https://github.com/apache/hudi/pull/12101#discussion_r1800767568
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/SparkBucketIndexPartitioner.java:
##########
@@ -130,6 +131,9 @@ public BucketInfo getBucketInfo(int bucketNumber) {
// Always write into log file instead of base file if using NB-CC
BucketType bucketType = isNonBlockingConcurrencyControl ?
BucketType.UPDATE : BucketType.INSERT;
String fileIdPrefix = BucketIdentifier.newBucketFileIdPrefix(bucketId,
isNonBlockingConcurrencyControl);
+ if (isNonBlockingConcurrencyControl) {
+ fileIdPrefix = FSUtils.createNewFileId(fileIdPrefix, 0);
+ }
Review Comment:
> Could this be combined with L133 since L133 also uses the flag
`isNonBlockingConcurrencyControl`?
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
