danny0405 commented on code in PR #12101:
URL: https://github.com/apache/hudi/pull/12101#discussion_r1800928369
##########
hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/table/action/commit/SparkBucketIndexPartitioner.java:
##########
@@ -130,6 +131,9 @@ public BucketInfo getBucketInfo(int bucketNumber) {
// Always write into log file instead of base file if using NB-CC
BucketType bucketType = isNonBlockingConcurrencyControl ?
BucketType.UPDATE : BucketType.INSERT;
String fileIdPrefix = BucketIdentifier.newBucketFileIdPrefix(bucketId,
isNonBlockingConcurrencyControl);
+ if (isNonBlockingConcurrencyControl) {
+ fileIdPrefix = FSUtils.createNewFileId(fileIdPrefix, 0);
+ }
Review Comment:
@yihua The NBCC writer would skip the conflict resolution, but the OCC
writer would still resolve conflicts with OCC strategies. For single insert
writer, there should be no conflicts if there is not small file group merging.
But generally the NB-CC is just designed for upsert scenarios, the
combination of NBCC and OCC is not suggested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
