yihua commented on code in PR #11947:
URL: https://github.com/apache/hudi/pull/11947#discussion_r1802125316
##########
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieDefaultTimeline.java:
##########
@@ -629,16 +649,23 @@ private Set<String>
getOrCreatePendingClusteringInstantSet() {
/**
* Returns the first non savepoint commit on the timeline.
*/
- private static Option<HoodieInstant>
findFirstNonSavepointCommit(List<HoodieInstant> instants) {
+ private static Option<HoodieInstant> findFirstNonSavepointCommit(
+ List<HoodieInstant> instants,
+ boolean byCompletionTime) {
Review Comment:
Fixed. I also improved the logic to be simpler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
