yihua commented on code in PR #11947:
URL: https://github.com/apache/hudi/pull/11947#discussion_r1802135861
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/hudi/IncrementalRelation.scala:
##########
@@ -90,24 +78,24 @@ class IncrementalRelation(val sqlContext: SQLContext,
throw new HoodieException("Incremental queries are not supported when meta
fields are disabled")
}
+ private val queryContext: IncrementalQueryAnalyzer.QueryContext =
+ IncrementalQueryAnalyzer.builder()
+ .metaClient(metaClient)
+ .startTime(optParams(DataSourceReadOptions.BEGIN_INSTANTTIME.key))
+ .endTime(optParams.getOrElse(DataSourceReadOptions.END_INSTANTTIME.key,
null))
+ .rangeType(InstantRange.RangeType.OPEN_CLOSED)
+ .build()
+ .analyze()
+
+ private val commitsToReturn = List.concat(
+ queryContext.getArchivedInstants.asScala,
+ queryContext.getActiveInstants.asScala)
Review Comment:
`queryContext.instants` contains only the instant times. There is one place
below that needs to get the replaced instants from `commitsToReturn` based on
the action type, so `queryContext.getArchivedInstants` and
`queryContext.getActiveInstants` are used. Another way is to make
`queryContext.instants` store `HoodieInstant` instead of `String` of instant
times.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
