yihua commented on code in PR #11947:
URL: https://github.com/apache/hudi/pull/11947#discussion_r1802427060
##########
hudi-spark-datasource/hudi-spark-common/src/main/scala/org/apache/spark/sql/hudi/streaming/HoodieStreamSource.scala:
##########
@@ -114,19 +99,14 @@ class HoodieStreamSource(
private def getLatestOffset: Option[HoodieSourceOffset] = {
metaClient.reloadActiveTimeline()
- val filteredTimeline = handleHollowCommitIfNeeded(
- metaClient.getActiveTimeline.filterCompletedInstants(), metaClient,
hollowCommitHandling)
+ val filteredTimeline =
metaClient.getActiveTimeline.filterCompletedInstants()
filteredTimeline match {
case activeInstants if !activeInstants.empty() =>
- val timestamp = if (hollowCommitHandling == USE_TRANSITION_TIME) {
- activeInstants.getInstantsOrderedByCompletionTime
- .skip(activeInstants.countInstants() - 1)
- .findFirst()
- .get()
- .getCompletionTime
- } else {
- activeInstants.lastInstant().get().getTimestamp
- }
+ val timestamp = activeInstants.getInstantsOrderedByCompletionTime
+ .skip(activeInstants.countInstants() - 1)
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
