yihua commented on code in PR #11947:
URL: https://github.com/apache/hudi/pull/11947#discussion_r1802553652
##########
hudi-common/src/main/java/org/apache/hudi/common/table/read/IncrementalQueryAnalyzer.java:
##########
@@ -376,14 +382,16 @@ private QueryContext(
List<HoodieInstant> archivedInstants,
List<HoodieInstant> activeInstants,
HoodieTimeline activeTimeline,
- @Nullable HoodieTimeline archivedTimeline) {
+ @Nullable HoodieTimeline archivedTimeline,
+ @Nullable String predicateFilter) {
this.startInstant = Option.ofNullable(startInstant);
this.endInstant = Option.ofNullable(endInstant);
this.archivedInstants = archivedInstants;
this.activeInstants = activeInstants;
this.activeTimeline = activeTimeline;
this.archivedTimeline = archivedTimeline;
this.instants = instants;
+ this.predicateFilter = Option.ofNullable(predicateFilter);
Review Comment:
Makes sense. The predicate is decoupled from `QueryContext`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
