the-other-tim-brown commented on code in PR #11853:
URL: https://github.com/apache/hudi/pull/11853#discussion_r1804944985
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamSync.java:
##########
@@ -1219,14 +1243,13 @@ private Pair<HoodieWriteConfig, Schema>
getHoodieClientConfigAndWriterSchema(Sch
return Pair.of(config, returnSchema);
}
- private Schema getSchemaForWriteConfig(Schema targetSchema) {
+ private Schema getSchemaForWriteConfig(Schema targetSchema,
HoodieTableMetaClient metaClient) {
Review Comment:
I've gone back and forth on this myself. I think that the original intention
is that the meta client always reflects the current state and therefore doesn't
need to exist outside the scope of a single sync. I am curious to hear what
others think and I am open to changing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
