yihua commented on code in PR #11853:
URL: https://github.com/apache/hudi/pull/11853#discussion_r1817951052
##########
hudi-utilities/src/main/java/org/apache/hudi/utilities/streamer/StreamSync.java:
##########
@@ -1219,14 +1243,13 @@ private Pair<HoodieWriteConfig, Schema>
getHoodieClientConfigAndWriterSchema(Sch
return Pair.of(config, returnSchema);
}
- private Schema getSchemaForWriteConfig(Schema targetSchema) {
+ private Schema getSchemaForWriteConfig(Schema targetSchema,
HoodieTableMetaClient metaClient) {
Review Comment:
I think it's better keep the meta client within the scope of a single sync
and pass it around for reuse without keeping a `metaClient` member which is
error-prone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
