yihua commented on code in PR #11943:
URL: https://github.com/apache/hudi/pull/11943#discussion_r1805578798


##########
hudi-common/src/main/java/org/apache/hudi/common/model/HoodieRecordPayload.java:
##########
@@ -140,4 +141,15 @@ default Comparable<?> getOrderingValue() {
     // default natural order
     return 0;
   }
+
+  static String getAvroPayloadForMergeMode(RecordMergeMode mergeMode) {
+    switch (mergeMode) {
+      //TODO: After we have merge mode working for writing, we should have a 
dummy payload that will throw exception when used
+      default:

Review Comment:
   Should `CUSTOM` mode be handled too?  Is it easier to store the payload 
class name in the `RecordMergeMode` enum itself?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to