yihua commented on code in PR #11943:
URL: https://github.com/apache/hudi/pull/11943#discussion_r1805681819
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/TestHoodieTableConfig.java:
##########
@@ -266,15 +266,15 @@ public void testDropInvalidConfigs() {
// test valid ones are not dropped
config = new HoodieConfig();
config.setValue(HoodieTableConfig.VERSION,
String.valueOf(HoodieTableVersion.EIGHT.versionCode()));
- config.setValue(RECORD_MERGE_MODE, RECORD_MERGE_MODE.defaultValue());
+ config.setValue(RECORD_MERGE_MODE,
RECORD_MERGE_MODE.defaultValue().name());
HoodieTableConfig.dropInvalidConfigs(config);
assertTrue(config.contains(RECORD_MERGE_MODE));
}
@Test
public void testDefinedTableConfigs() {
List<ConfigProperty<?>> configProperties =
HoodieTableConfig.definedTableConfigs();
- assertEquals(37, configProperties.size());
+ assertEquals(36, configProperties.size());
Review Comment:
Should we add new tests around the logic of inferring the merge configs?
##########
hudi-hadoop-common/src/test/java/org/apache/hudi/common/table/TestHoodieTableMetaClient.java:
##########
@@ -126,136 +114,6 @@ public void testCommitTimeline() {
"Commit value should be \"test-detail\"");
}
- private static Stream<Arguments> argumentsForInferringRecordMergeMode() {
Review Comment:
Wondering if these tests are repurposed elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
