danny0405 commented on code in PR #12105:
URL: https://github.com/apache/hudi/pull/12105#discussion_r1807570287
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -179,6 +181,7 @@ protected
HoodieBackedTableMetadataWriter(StorageConfiguration<?> storageConf,
.setBasePath(dataWriteConfig.getBasePath())
.setTimeGeneratorConfig(dataWriteConfig.getTimeGeneratorConfig()).build();
this.enabledPartitionTypes =
getEnabledPartitions(dataWriteConfig.getProps(), dataMetaClient);
+ this.initializedPartitionTypes = new
ArrayList<>(enabledPartitionTypes.size());
Review Comment:
I didn't see any usage of this variable.
##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java:
##########
@@ -233,7 +236,7 @@ public List<MetadataPartitionType>
getEnabledPartitionTypes() {
* Initialize the metadata table if needed.
*
* @param dataMetaClient - meta client for the data table
- * @param inflightInstantTimestamp - timestamp of an instant in progress on
the dataset
+ * @param inflightInstantTimestamp - timestamp of an instant in
progress on the dataset
Review Comment:
unnecessary change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]