danny0405 commented on code in PR #12105:
URL: https://github.com/apache/hudi/pull/12105#discussion_r1807576722
##########
hudi-common/src/main/java/org/apache/hudi/metadata/HoodieTableMetadataUtil.java:
##########
@@ -1225,11 +1218,22 @@ private static Stream<HoodieRecord>
translateWriteStatToColumnStats(HoodieWriteS
}
private static Stream<HoodieRecord> getColumnStatsRecords(String
partitionPath,
- String filePath,
+ String
filePathWithPartition,
HoodieTableMetaClient datasetMetaClient,
List<String>
columnsToIndex,
boolean isDeleted)
{
- String filePartitionPath = filePath.startsWith("/") ?
filePath.substring(1) : filePath;
+ return getColumnStatsRecords(partitionPath, filePathWithPartition,
datasetMetaClient, columnsToIndex, isDeleted, false, Option.empty(), -1);
+ }
+
+ private static Stream<HoodieRecord> getColumnStatsRecords(String
partitionPath,
+ String
filePathWithPartition,
+
HoodieTableMetaClient datasetMetaClient,
+ List<String>
columnsToIndex,
+ boolean isDeleted,
+ boolean
fetchStatsForLogFiles,
+ Option<Schema>
writerSchemaOpt,
+ int maxBufferSize)
{
+ String filePartitionPath = filePathWithPartition.startsWith("/") ?
filePathWithPartition.substring(1) : filePathWithPartition;
Review Comment:
Isn't the partitionPath already there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
