yihua commented on code in PR #12105:
URL: https://github.com/apache/hudi/pull/12105#discussion_r1815843608
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSecondaryIndexPruning.scala:
##########
@@ -614,7 +610,7 @@ class TestSecondaryIndexPruning extends
SparkClientFunctionalTestHarness {
checkAnswer(s"select ts, record_key_col, not_record_key_col,
partition_key_col from $tableName where record_key_col = 'row1'")(
Seq(1, "row1", "xyz", "p1")
)
- verifyQueryPredicate(hudiOpts, "not_record_key_col")
+ verifyQueryPredicate(hudiOpts, "not_record_key_col","abc")
Review Comment:
```suggestion
verifyQueryPredicate(hudiOpts, "not_record_key_col", "abc")
```
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSecondaryIndexPruning.scala:
##########
@@ -770,11 +766,11 @@ class TestSecondaryIndexPruning extends
SparkClientFunctionalTestHarness {
assertFalse(metaClient.getTableConfig.getMetadataPartitions.contains(MetadataPartitionType.PARTITION_STATS.getPartitionPath))
// however index definition should still be present
assertTrue(metaClient.getIndexMetadata.isPresent &&
metaClient.getIndexMetadata.get.getIndexDefinitions.get(secondaryIndexPartition).getIndexType.equals("secondary_index"))
+
// update the secondary key column
spark.sql(s"update $tableName set not_record_key_col = 'xyz' where
record_key_col = 'row1'")
// validate the secondary index records themselves
checkAnswer(s"select key, SecondaryIndexMetadata.recordKey,
SecondaryIndexMetadata.isDeleted from hudi_metadata('$basePath') where type=7")(
- Seq("abc", "row1", true),
Review Comment:
Similar here.
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSecondaryIndexPruning.scala:
##########
@@ -605,7 +602,6 @@ class TestSecondaryIndexPruning extends
SparkClientFunctionalTestHarness {
spark.sql(s"update $tableName set not_record_key_col = 'xyz' where
record_key_col = 'row1'")
// validate the secondary index records themselves
checkAnswer(s"select key, SecondaryIndexMetadata.recordKey,
SecondaryIndexMetadata.isDeleted from hudi_metadata('$basePath') where type=7")(
- Seq("abc", "row1", true),
Review Comment:
Similar here.
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSecondaryIndexPruning.scala:
##########
@@ -516,8 +515,6 @@ class TestSecondaryIndexPruning extends
SparkClientFunctionalTestHarness {
|FROM hudi_metadata('$basePath')
|WHERE type=7
""".stripMargin)(
- Seq("abc", "row1", true),
- Seq("cde", "row2", true),
Review Comment:
Why removing this? Are the expected results changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
