yihua commented on code in PR #12105:
URL: https://github.com/apache/hudi/pull/12105#discussion_r1815847958
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/ColumnStatIndexTestBase.scala:
##########
@@ -269,14 +330,42 @@ object ColumnStatIndexTestBase {
def testMetadataColumnStatsIndexParams: java.util.stream.Stream[Arguments] =
{
java.util.stream.Stream.of(HoodieTableType.values().toStream.flatMap(tableType
=>
Seq(Arguments.arguments(ColumnStatsTestCase(tableType,
shouldReadInMemory = true)),
- Arguments.arguments(ColumnStatsTestCase(tableType, shouldReadInMemory
= false)))
+ Arguments.arguments(ColumnStatsTestCase(tableType, shouldReadInMemory
= false))
+ )
): _*)
}
def testMetadataColumnStatsIndexParamsForMOR:
java.util.stream.Stream[Arguments] = {
java.util.stream.Stream.of(
Seq(Arguments.arguments(ColumnStatsTestCase(HoodieTableType.MERGE_ON_READ,
shouldReadInMemory = true)),
- Arguments.arguments(ColumnStatsTestCase(HoodieTableType.MERGE_ON_READ,
shouldReadInMemory = false)))
- : _*)
+ Arguments.arguments(ColumnStatsTestCase(HoodieTableType.MERGE_ON_READ,
shouldReadInMemory = false))
+ )
+ : _*)
}
+
+ def testTableTypePartitionTypeParams: java.util.stream.Stream[Arguments] = {
+ java.util.stream.Stream.of(
+ Seq(
+ Arguments.arguments(HoodieTableType.COPY_ON_WRITE, "c8"),
+ // empty partition col represents non-partitioned table.
+ Arguments.arguments(HoodieTableType.COPY_ON_WRITE, ""),
+ Arguments.arguments(HoodieTableType.MERGE_ON_READ, "c8"),
+ Arguments.arguments(HoodieTableType.MERGE_ON_READ, "")
+ )
+ : _*)
+ }
+
+ case class DoWriteAndValidateColumnStatsParams(testCase: ColumnStatsTestCase,
Review Comment:
```suggestion
case class ColumnStatsTestParams(testCase: ColumnStatsTestCase,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
