nsivabalan commented on code in PR #12105:
URL: https://github.com/apache/hudi/pull/12105#discussion_r1816060699
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSecondaryIndexPruning.scala:
##########
@@ -516,8 +515,6 @@ class TestSecondaryIndexPruning extends
SparkClientFunctionalTestHarness {
|FROM hudi_metadata('$basePath')
|WHERE type=7
""".stripMargin)(
- Seq("abc", "row1", true),
- Seq("cde", "row2", true),
Review Comment:
yes. since we fixed the how cleaning impacts MDT, where we delete the record
instead of just holding onto the key, and null stat value. hence had to fix the
expected values in these tests.
##########
hudi-spark-datasource/hudi-spark/src/test/scala/org/apache/hudi/functional/TestSecondaryIndexPruning.scala:
##########
@@ -605,7 +602,6 @@ class TestSecondaryIndexPruning extends
SparkClientFunctionalTestHarness {
spark.sql(s"update $tableName set not_record_key_col = 'xyz' where
record_key_col = 'row1'")
// validate the secondary index records themselves
checkAnswer(s"select key, SecondaryIndexMetadata.recordKey,
SecondaryIndexMetadata.isDeleted from hudi_metadata('$basePath') where type=7")(
- Seq("abc", "row1", true),
Review Comment:
same here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
