yihua commented on code in PR #12105:
URL: https://github.com/apache/hudi/pull/12105#discussion_r1815525018
##########
hudi-common/src/main/java/org/apache/hudi/common/fs/FSUtils.java:
##########
@@ -154,6 +154,14 @@ public static String getFileId(String fullFileName) {
return fullFileName.split("_", 2)[0];
}
+ /**
+ * @param filePath
+ * @returns the filename from the given path. Path could be the absolute
path or just partition path and file name.
+ */
+ public static String getFileNameFromFilePath(String filePath) {
Review Comment:
```suggestion
public static String getFileNameFromPath(String filePath) {
```
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/HoodieUnMergedLogRecordScanner.java:
##########
@@ -83,7 +83,7 @@ protected <T> void processNextRecord(HoodieRecord<T>
hoodieRecord) throws Except
@Override
protected void processNextDeletedRecord(DeleteRecord deleteRecord) {
- throw new IllegalStateException("Not expected to see delete records in
this log-scan mode. Check Job Config");
+ // no - op
Review Comment:
This seems irrelevant?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
