yihua commented on code in PR #12122:
URL: https://github.com/apache/hudi/pull/12122#discussion_r1819884437
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/AbstractHoodieLogRecordReader.java:
##########
@@ -167,7 +167,7 @@ protected AbstractHoodieLogRecordReader(HoodieStorage
storage, String basePath,
this.payloadClassFQN = tableConfig.getPayloadClass();
this.preCombineField = tableConfig.getPreCombineField();
// Log scanner merge log with precombine
- TypedProperties props = new TypedProperties();
+ TypedProperties props = hoodieTableMetaClient.getTableConfig().getProps();
Review Comment:
It's better to strictly keep the required props here, i.e., the ordering
field prop.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
