linliu-code commented on code in PR #12122:
URL: https://github.com/apache/hudi/pull/12122#discussion_r1819930103
##########
hudi-common/src/main/java/org/apache/hudi/common/table/log/BaseHoodieMergedLogRecordScanner.java:
##########
@@ -87,6 +94,11 @@ protected BaseHoodieMergedLogRecordScanner(HoodieStorage
storage, String basePat
this.records = new ExternalSpillableMap<>(maxMemorySizeInBytes,
spillableMapBasePath, new DefaultSizeEstimator(),
new HoodieRecordSizeEstimator(readerSchema), diskMapType,
isBitCaskDiskMapCompressionEnabled);
this.scannedPrefixes = new HashSet<>();
+
+ // TODO: use reader context for both non fg reader.
+ this.orderingFieldName =
Option.ofNullable(ConfigUtils.getOrderingField(payloadProps)).orElseGet(() ->
hoodieTableMetaClient.getTableConfig().getPreCombineField());
+ this.orderingFieldType =
AvroSchemaUtils.findNestedFieldType(readerSchema,
this.orderingFieldName).orElse(Schema.Type.INT);
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
